add declarative config for baggage #2031
Open
+153
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
baggage-declarative-config
branch
from
f89cb52 to
507cef9
Compare
|
@jaydeluca please have a look |
trask
reviewed
Aug 18, 2025
Comment on lines
+16
to
+17
| compileOnly("io.opentelemetry:opentelemetry-sdk-common") | ||
| compileOnly("io.opentelemetry:opentelemetry-sdk-extension-incubator") |
There was a problem hiding this comment.
what's the reason for compileOnly vs implementation?
There was a problem hiding this comment.
the auto configuration is optional - programmatic config should not pull unneeded deps
trask
approved these changes
Aug 19, 2025
| import com.google.auto.service.AutoService; | ||
| import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties; | ||
| import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider; | ||
| import io.opentelemetry.sdk.internal.IncludeExcludePredicate; |
There was a problem hiding this comment.
can you add a tracking issue for making this public if we think it's generally useful enough? it's ok for now but trying to slowly reduce our dependency on internal classes (similar to open-telemetry/opentelemetry-java#6970)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2013